How to provide a good pull request

A jOOQ user just provided me with an awesome pull request. Check this out:

What’s so nice about this particular pull request:

  • It has a couple of little refactoring steps
  • It contains a little regression test
  • Only at the end, it contains the actual fix

This is really nice. With these many commits, I can easily review the pull request, which makes it easy to decide whether it should make it into the code base or not.